Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W3C tracecontext propagation #1700

Closed
suman-aella opened this issue Jul 29, 2020 · 4 comments
Closed

W3C tracecontext propagation #1700

suman-aella opened this issue Jul 29, 2020 · 4 comments

Comments

@suman-aella
Copy link

suman-aella commented Jul 29, 2020

Hi

This is a follow up to the feature request and also closed PR
#1540
openzipkin/brave#693

We would like to use the W3C trace context propagation for spring boot projects using sleuth. With included support of the w3c specified traceheaders.
Currently I see the development happening in the new repo
https://github.com/openzipkin-contrib/brave-propagation-w3c

I see that currently the above propagation repo uses brave 5.12.3 versions and not compatible with latest Sleuth which uses brave 5.9.
Is the Sleuth update to be done once this feature is released. Could you advice me on its usage for my Spring sleuth projects. Should I go with my own implementation if not.

Thanks

@marcingrzejszczak
Copy link
Contributor

@suman-aella
Copy link
Author

Ok. I see that my Springcloud version has affected the zipkin brave dependency version.
Once I updated the SpringCloudVersion from 'Hoxton.SR1' to ''Hoxton.SR5'' the latest brave version 5.12.3 got reflected in the dependencies under the "spring-cloud-starter-zipkin" artifatct.

@marcingrzejszczak
Copy link
Contributor

Cool, can we close this then?

@suman-aella
Copy link
Author

Cool, can we close this then?

yes we can. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants