Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Informers instead of Watcher in reload for fabric8 #1035

Closed
wind57 opened this issue Jun 15, 2022 · 1 comment · Fixed by #1036
Closed

Use Informers instead of Watcher in reload for fabric8 #1035

wind57 opened this issue Jun 15, 2022 · 1 comment · Fixed by #1036
Labels
enhancement
Milestone
3.0.0-M4

Comments

@wind57
Copy link
Contributor

wind57 commented Jun 15, 2022

Currently, k8s-native client dependency uses informers for reload functionality, but fabric8 uses watches. We should use informers instead of watchers in fabric8 also.
@wind57
Copy link
Contributor Author

wind57 commented Jul 7, 2022

@ryanjbaxter since you merged the last PR, this can be closed also.

@ryanjbaxter ryanjbaxter added this to the 3.0.0-M4 milestone Jul 7, 2022
@ryanjbaxter ryanjbaxter linked a pull request Jul 7, 2022 that will close this issue
Reload functionality clean-up part 4 #1036
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.0.0-M4
Development

Successfully merging a pull request may close this issue.

Reload functionality clean-up part 4 wind57/spring-cloud-kubernetes
3 participants
@ryanjbaxter @wind57 @spring-cloud-issues