This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 693
Allow projectId
override in Firebase authentication
#2405
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2405 +/- ##
============================================
- Coverage 74.00% 73.97% -0.03%
- Complexity 2108 2109 +1
============================================
Files 263 263
Lines 7604 7609 +5
Branches 787 788 +1
============================================
+ Hits 5627 5629 +2
- Misses 1614 1616 +2
- Partials 363 364 +1
Continue to review full report at Codecov.
|
eddumelendez
suggested changes
May 30, 2020
...ramework/cloud/gcp/autoconfigure/security/FirebaseAuthenticationProjectIdEvaluatorTests.java
Outdated
Show resolved
Hide resolved
...ringframework/cloud/gcp/autoconfigure/security/FirebaseAuthenticationProjectIdEvaluator.java
Outdated
Show resolved
Hide resolved
...ramework/cloud/gcp/autoconfigure/security/FirebaseAuthenticationProjectIdEvaluatorTests.java
Outdated
Show resolved
Hide resolved
eddumelendez
approved these changes
May 30, 2020
ttomsu
approved these changes
Jun 1, 2020
...ringframework/cloud/gcp/autoconfigure/security/FirebaseAuthenticationProjectIdEvaluator.java
Outdated
Show resolved
Hide resolved
meltsufin
suggested changes
Jun 1, 2020
...ringframework/cloud/gcp/autoconfigure/security/FirebaseAuthenticationProjectIdEvaluator.java
Outdated
Show resolved
Hide resolved
eddumelendez
reviewed
Jun 2, 2020
...pringframework/cloud/gcp/autoconfigure/security/FirebaseAuthenticationAutoConfiguration.java
Outdated
Show resolved
Hide resolved
meltsufin
approved these changes
Jun 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution again, @femrtnz!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi All,
This is my first PR on spring-cloud. Please let me know if you have any questions or suggestions.
Fixes #2178, I'm enabling the project ID to be set on
FirebaseAuthenticationProperties.java
so you can use a different project ID