Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Add support for Firestore Sort PartTree queries #2341

Merged
merged 2 commits into from
Apr 29, 2020
Merged

Conversation

dzou
Copy link
Contributor

@dzou dzou commented Apr 29, 2020

This allows user to add the Sort parameter to their Firestore repository query methods.

Fixes #1940.

@dzou dzou requested review from dmitry-s and meltsufin April 29, 2020 00:35
@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #2341 into master will increase coverage by 0.59%.
The diff coverage is 65.21%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2341      +/-   ##
============================================
+ Coverage     73.75%   74.35%   +0.59%     
- Complexity     2089     2117      +28     
============================================
  Files           259      259              
  Lines          7507     7544      +37     
  Branches        772      781       +9     
============================================
+ Hits           5537     5609      +72     
+ Misses         1615     1574      -41     
- Partials        355      361       +6     
Flag Coverage Δ Complexity Δ
#integration ? ?
#unittests 74.35% <65.21%> (+0.59%) 2117.00 <2.00> (+28.00)
Impacted Files Coverage Δ Complexity Δ
...store/repository/query/PartTreeFirestoreQuery.java 90.29% <65.21%> (-0.08%) 24.00 <2.00> (+3.00) ⬇️
...tastore/GcpDatastoreEmulatorAutoConfiguration.java 58.62% <0.00%> (-6.90%) 6.00% <0.00%> (ø%)
...store/repository/query/PartTreeDatastoreQuery.java 91.06% <0.00%> (-0.30%) 65.00% <0.00%> (+5.00%) ⬇️
...a/firestore/SimpleFirestoreReactiveRepository.java 19.04% <0.00%> (+19.04%) 1.00% <0.00%> (+1.00%)
...fig/FirestoreRepositoryConfigurationExtension.java 56.25% <0.00%> (+56.25%) 4.00% <0.00%> (+4.00%)
...ry/support/ReactiveFirestoreRepositoryFactory.java 80.00% <0.00%> (+80.00%) 4.00% <0.00%> (+4.00%)
...restore/repository/query/FirestoreQueryMethod.java 100.00% <0.00%> (+100.00%) 2.00% <0.00%> (+2.00%)
...pository/support/FirestoreQueryLookupStrategy.java 100.00% <0.00%> (+100.00%) 2.00% <0.00%> (+2.00%)
...ository/config/FirestoreRepositoriesRegistrar.java 100.00% <0.00%> (+100.00%) 3.00% <0.00%> (+3.00%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 045e857...4569910. Read the comment docs.

dmitry-s
dmitry-s previously approved these changes Apr 29, 2020
meltsufin
meltsufin previously approved these changes Apr 29, 2020
Copy link
Contributor

@meltsufin meltsufin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dzou dzou dismissed stale reviews from meltsufin and dmitry-s via 4569910 April 29, 2020 17:51
@dzou dzou requested a review from meltsufin April 29, 2020 17:57
@sonarcloud
Copy link

sonarcloud bot commented Apr 29, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

85.2% 85.2% Coverage
0.0% 0.0% Duplication

@dzou dzou merged commit 13f91a7 into master Apr 29, 2020
@dzou dzou deleted the firestore-pageable branch April 29, 2020 18:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add Sort support for PartTree methods
3 participants