-
Notifications
You must be signed in to change notification settings - Fork 693
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2300 +/- ##
============================================
- Coverage 80.95% 72.68% -8.28%
+ Complexity 2309 2063 -246
============================================
Files 258 258
Lines 7456 7464 +8
Branches 762 763 +1
============================================
- Hits 6036 5425 -611
- Misses 1100 1689 +589
- Partials 320 350 +30
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From in person review.
@@ -140,6 +140,9 @@ Spring Data generates a working implementation of the specified interface, which | |||
|
|||
The `User` type parameter to `FirestoreReactiveRepository` refers to the underlying domain type. | |||
|
|||
NOTE: `_` character can be used to refer to embedded properties. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't need to use the underscore according to this:
https://docs.spring.io/spring-data/jpa/docs/current/reference/html/#repositories.query-methods.query-property-expressions
@@ -170,6 +172,19 @@ public Object execute(Object[] parameters) { | |||
return builder; | |||
} | |||
|
|||
private String getName(Part part) { | |||
Iterator<PropertyPath> iterator = part.getProperty().iterator(); | |||
Iterable<PropertyPath> iterable = () -> iterator; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
combine these two lines into one?
...loud-gcp-data-firestore/src/test/java/org/springframework/cloud/gcp/data/firestore/User.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From in person review.
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
fixes #2198