Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring Cloud Function context has an optional scope on "spring-boot-starter-test" #1062

Closed
snicoll opened this issue Jul 30, 2023 · 4 comments
Closed

Spring Cloud Function context has an optional scope on "spring-boot-starter-test" #1062

snicoll opened this issue Jul 30, 2023 · 4 comments
Assignees
@olegz

Comments

@snicoll
Copy link

snicoll commented Jul 30, 2023

This optional flag looks odd to me, spotted while working on metadata verification tests for start.spring.io.

Shouldn't it be a test scope?
@snicoll
Copy link
Author

snicoll commented Jul 30, 2023

I believe the exclude can be dropped as well. We've removed support for that JSON dependency since 2.0.

@olegz olegz self-assigned this Aug 30, 2023
@olegz olegz added this to the 4.1 milestone Aug 30, 2023
@olegz
Copy link
Contributor

olegz commented Aug 30, 2023

Hey Stephan, actually it is correct as a while back @dsyer had created a few support classes to be used by tests. In other words we actually depend on int outside of tests.

Please let me know if you still have any concerns.

@olegz olegz removed this from the 4.1 milestone Aug 30, 2023
@snicoll

This comment was marked as outdated.

Sign in to view
@snicoll
Copy link
Author

snicoll commented Aug 30, 2023

Ah nevermind, I mixed up with another issue.

@snicoll snicoll closed this as not planned Won't fix, can't repro, duplicate, stale Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olegz olegz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@olegz @snicoll