Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network deployer property has no effect #199

Open
DemianTinkiel opened this issue Dec 21, 2020 · 0 comments
Open

network deployer property has no effect #199

DemianTinkiel opened this issue Dec 21, 2020 · 0 comments
Assignees

Comments

@DemianTinkiel
Copy link

In a docker-compose local deployment, changing the property for docker network has no effect. Containers are always part of bridge and the never created. I've also tried creating the network manually before property setting but containers are never added to it.

Looking at org.springframework.cloud.deployer.spi.local.DockerCommandBuilder, I see that the network is passed on the constructor. After putting a log at the end of the constructor I saw that the class is initialized immediately upon skipper start and the property is never updated after. I suspect that is the root of the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants