Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance configuration of admin credentials for actuator access #483

Open
dturanski opened this issue Feb 11, 2022 · 1 comment
Open

Enhance configuration of admin credentials for actuator access #483

dturanski opened this issue Feb 11, 2022 · 1 comment
Assignees
Labels
status/need-investigation Oh need to look under a hood
Milestone

Comments

@dturanski
Copy link
Contributor

Depends on #478

Currently, the configuration for src/kubernetes/skipper/skipper-config-<binder>.yaml looks like

data:
  application.yaml: |-
    spring:
      cloud:
        skipper:
          server:
            platform:
              kubernetes:
                accounts:
                  default:
                    appAdmin:
                      user: ${app-admin-user}
                      password: ${app-admin-password}
...

These come from a secretKey ref. Like

apiVersion: v1
kind: Secret
metadata:
  name: skipper
  labels:
    app: skipper
data:
  app-admin-password: cGFzc3dvcmQ=
  app-admin-user: YWN0dWF0b3I=

The deployer needs to pass these creds to the ActuatorTemplate as currently implemented. We maybe can add something like adminSecretName to the k8s deployer properties and use that to configure the app container instead of passing the creds as args.

@markpollack
Copy link
Contributor

This is an experimental feature request, valid but lower priority for us to address. Look post 2.10 SCDF release.

@markpollack markpollack added this to the General Backlog milestone Jul 27, 2022
@markpollack markpollack added the status/need-investigation Oh need to look under a hood label Oct 18, 2022
@markpollack markpollack modified the milestones: 2.8.0-RC1, 2.9.0-M1 Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/need-investigation Oh need to look under a hood
Projects
None yet
Development

No branches or pull requests

3 participants