Skip to content
This repository has been archived by the owner on Feb 23, 2023. It is now read-only.

Add support for "spring-cloud-starter-circuitbreaker-resilience4j" #960

Closed
goafabric opened this issue Aug 9, 2021 · 6 comments
Closed
Labels
for: external-project For an external project and not something we can fix

Comments

@goafabric
Copy link

Following the implementation Guidline of spring-cloud
i implemented a Resilience4j CircuitBreaker basically by implementing the suggested
CircuitBreakerFactory.create().run

Will it works perfectly fine in JVM ... it does not work in native mode.
The application compiles and even bootstraps .. it even seems to wrap everything inside the CircuitBreaker.run Lambda,
but the CircuitBreaker is never been tripped.

Also the registered Health Indicator shows nothing.

As this library is currently not listed within the list of compatible libraries,
i guess this is somehow expected ...

However, as with Flyway this is a very essential part for every Service Application
so support would be highly appreciated.

thx

Andreas

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Aug 9, 2021
@sdeleuze
Copy link
Contributor

@ryanjbaxter @spencergibb Could you please qualify this issue, does it make sense to add it to the backlog?

@sdeleuze sdeleuze added the status: waiting-for-feedback We need additional information before we can continue label Aug 17, 2021
@ryanjbaxter
Copy link

I think so, yes.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Aug 17, 2021
@mhalbritter mhalbritter added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on status: feedback-provided Feedback has been provided labels Jun 9, 2022
@mhalbritter mhalbritter added this to the Backlog milestone Jun 9, 2022
@goafabric
Copy link
Author

@mhalbritter
I can happily confirm that resilience4j now works .. automagically ... at least the imperative version with "cbFactory".
I guess we (again) had some changes here in the background either in native or graalvm itself.

The Resilience4j Circuitbreaker annotation also works at least in JVM mode .. which is not really documented.
But NOT in Native mode ....
Bu it guess that is more related to the current state of AOP Support and not supporing Annotations:
#956

@goafabric
Copy link
Author

I can also confirm that this works perfectly fine with Spring Boot 3.0, via the "cbFactory"
However @CIRCUITBREAKER does not work.
Would be great if this will supported also .. and afterwards the ticket could be closed.

@mhalbritter
Copy link
Contributor

Hey @goafabric, thanks for the update. Spring Native is in minimal maintenance mode. If you find that something doesn't work in Spring Boot 3.x, please open an issue on the corresponding issue tracker. For @CircuitBreaker please see https://github.com/spring-projects/spring-retry or https://github.com/spring-cloud/spring-cloud-circuitbreaker.

@goafabric
Copy link
Author

@mhalbritter
ok will do .. created on new issue inside spring cloud ..
spring-cloud/spring-cloud-circuitbreaker#159

so i will close this one

@mhalbritter mhalbritter added for: external-project For an external project and not something we can fix and removed type: enhancement A general enhancement labels Nov 18, 2022
@sdeleuze sdeleuze removed this from the Backlog milestone Jan 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
for: external-project For an external project and not something we can fix
Development

No branches or pull requests

5 participants