Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Streamline Pub/Sub ack executors #2245

Open
elefeint opened this issue Mar 11, 2020 · 1 comment
Open

Streamline Pub/Sub ack executors #2245

elefeint opened this issue Mar 11, 2020 · 1 comment
Labels
1.2.x backlog P3 pubsub GCP PubSub

Comments

@elefeint
Copy link
Contributor

  1. Replace default Pub/Sub ack executor with same-thread Runnable::run
  2. Create a custom executor only if max-acknowledgement-threads is specified

Per @mzeijen's comment.
@elefeint elefeint mentioned this issue Mar 11, 2020
Merged
@elefeint elefeint added the pubsub GCP PubSub label Mar 11, 2020
@meltsufin
Copy link
Contributor

We can also just remove max-acknowledgement-threads because it was never documented anyway.
The main unanswered question is whether direct executor (Runnable::run) will cause serious performance issues. If so, it shouldn't be the default.
For reference, the change was originally introduced in #1349.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
1.2.x backlog P3 pubsub GCP PubSub
Milestone
No milestone
Development

No branches or pull requests
2 participants
@meltsufin @elefeint