Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Spring Cloud GCP Starters in start.spring.io #181

Closed
saturnism opened this issue Sep 29, 2017 · 12 comments
Closed

Spring Cloud GCP Starters in start.spring.io #181

saturnism opened this issue Sep 29, 2017 · 12 comments
Milestone

Comments

@saturnism
Copy link
Contributor

Add the starters to start.spring.io

@joaoandremartins
Copy link
Contributor

The suggested list of starters is:

  1. spring-cloud-gcp-starter-core - Provides core functionality like GCP project ID and credentials providers.
  2. spring-cloud-gcp-starter-config - Enables Spring Cloud GCP Runtime Configuration.
  3. spring-cloud-gcp-starter-logging - Enables Spring Cloud GCP Logging.
  4. spring-cloud-gcp-starter-pubsub - Enables Spring Cloud GCP Pub/Sub. Auto-configures the Pub/Sub bits of spring-cloud-gcp-integration and spring-cloud-gcp-stream.
  5. spring-cloud-gcp-starter-sql - Enables Spring Cloud GCP JDBC for Cloud SQL.
  6. spring-cloud-gcp-starter-storage - Enables Spring Resources on Cloud Storage.
  7. spring-cloud-gcp-starter-trace - Enables Spring Cloud Sleuth through Stackdriver Trace.

This is similar to the list proposed in spring-io/initializr#539

@snicoll thoughts?

@snicoll
Copy link
Contributor

snicoll commented Jan 10, 2018

@snicoll thoughts?

Yes, we should finalize the issues that I've raised before discussing this please. The whole point of the single autoconfigure module is a sproing-cloud-gcp-starter that doesn't exist yet.

Also, I've already shared that we won't add all of them.

@meltsufin
Copy link
Contributor

Currently, spring-cloud-gcp-starter-core is an alias for spring-cloud-gcp-starter. How would you want to see it changed?

@joaoandremartins
Copy link
Contributor

@snicoll I was hoping we could get to a consensus sooner rather than later.

As I see it, the starters that will be added to Initializr don't depend on the list of issues from spring-io/initializr#539 (comment), so I thought we could have this conversation in parallel, but let me know if I'm missing anything.

It sounds like we could benefit from a VC meeting to discuss this. @meltsufin wdyt? Should we freeze some time later this week/earlier next week?

@snicoll
Copy link
Contributor

snicoll commented Jan 10, 2018

I am happy to discuss but the whole reason of the issues I've created is to come up with a situation where the code is ready to be consumed on start.spring.io. My proposal of having a base starter is key in this process, as I've indicated several times already.

I'd rather wait for that state to happen first.

@snicoll
Copy link
Contributor

snicoll commented Jan 10, 2018

Currently, spring-cloud-gcp-starter-core is an alias for spring-cloud-gcp-starter. How would you want to see it changed?

No it isn't. My proposal implies that the auto-configuration code will be made available with this starter and the starters themselves have no code. We're not there yet.

@meltsufin
Copy link
Contributor

@snicoll We're getting there with #276, which will be followed by another PR to make all starters have no code. #276 only does this for the config module, but it's a template for all others to follow next.

@joaoandremartins
Copy link
Contributor

We already have starters in Initializr.
This issue can now track adding more starters to Initializr.

@snicoll what are you first thoughts on adding the remaining Spring Cloud GCP starters to Initializr?

@snicoll
Copy link
Contributor

snicoll commented Apr 17, 2018

I think we should first document how to use start.spring.io to integrate with all the features that have been developed (we took the time to create a GCP support entry, I'd like us to document how users can use it). We also need to wait a bit and see how popular it is before considering adding more entries.

@meltsufin
Copy link
Contributor

@snicoll Where do you think the documentation for start.spring.io go? Our refdoc?

@snicoll
Copy link
Contributor

snicoll commented Apr 17, 2018

Anything that the GCP community can easily find. Can be on the github project, in the ref guide. If you have links we can add them in the metadata so I think that's quite interesting as well.

@joaoandremartins
Copy link
Contributor

I'll close here since we have the docs issue ready in #598.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

4 participants