Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional data_disk block attribtues on spotinst_stateful_node_azure resource #418

Open
Vittitow opened this issue Mar 24, 2023 · 0 comments
Labels
kind/feature Categorizes an issue or PR as related to a new feature or request.

Comments

@Vittitow
Copy link

Terraform Version

1.4.2

Description

Allow specifying the following attributes on the data_disk block of the spotinst_stateful_node_azure resource.

  • create_option
  • source_resource_id
  • on_demand_bursting_enabled
  • disk_iops_read_write

Use Cases

The main benefit of stateful nodes is the ability to persist the os and data disks. However, the current implementation only allows you to begin from an empty disk. It would be nice to be able to set the create option and source resource id to allow cloning from an existing snapshot/disk. Additionally, configurations like on demand bursting and iops read/write can't be specified when deploying via terraform.

I recognize you can import_vm's which would theoretically enable a lot of this but, if you deployed the vm's you're importing via terraform then it results in breaking the state of that deployment once spot kills the existing vm.

Potential Terraform Configuration

resource "spotinst_stateful_node_azure" "test_stateful_node_azure" {
  ...

  data_disk {
    size_gb                    = 2048
    lun                        = 1
    type                       = "Premium_LRS"
    create_option              = "Copy"
    source_resource_id         = "{source_resource_id}"
    on_demand_bursting_enabled = true
  }
}

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to help the community and maintainers prioritize this request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
@Vittitow Vittitow added the kind/feature Categorizes an issue or PR as related to a new feature or request. label Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes an issue or PR as related to a new feature or request.
Projects
None yet
Development

No branches or pull requests

1 participant