Fix file batch operation #5519
Merged
Fix file batch operation #5519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RustedBones
commented
Oct 24, 2024
Comment on lines
-129
to
-131
| Iterator<OutputT> i1 = outputs.iterator(); | ||
| Iterator<Element> i2 = batch.iterator(); | ||
| while (i1.hasNext() && i2.hasNext()) { |
There was a problem hiding this comment.
This parts assumes that List<Output> is 1:1 mapping of List<URI>
| @@ -104,7 +106,12 @@ public Path download(URI src) { | |||
| */ | |||
| public List<Path> download(List<URI> srcs) { | |||
| try { | |||
| return paths.getAll(srcs).values().asList(); | |||
There was a problem hiding this comment.
getAll(srcs) returns a Map<URI, Path>. Using values give no guarantee that returned Paths are ordered.
| if (batch.isEmpty()) { | ||
| return; | ||
| } | ||
| LOG.info("Processing batch of {}", batch.size()); | ||
| List<URI> uris = batch.stream().map(e -> e.uri).collect(Collectors.toList()); | ||
| remoteFileUtil.download(uris).stream().map(fn::apply).forEach(outputReceiver::output); |
There was a problem hiding this comment.
original element metadata are not passed back
RustedBones
force-pushed
the
fix-file-download-batch
branch
from
dd49ef0
to
15a8539
Compare
RustedBones
commented
Oct 24, 2024
| val paths = p.map { case ((_, f), _) => f }.distinct | ||
|
|
||
| val expected = (1L to 100L).map(i => (i.toString, i)) | ||
| contentAndTimestamp should containInAnyOrder(expected) |
There was a problem hiding this comment.
Ran on the original code, got non expected item (1, 10) -> (1st element was flushed while processing the 10th)
RemoteFileUtil did not preserve element ordering wich was assumed in the FileDownloadDoFn Pane information was not propagated
RustedBones
force-pushed
the
fix-file-download-batch
branch
from
15a8539
to
fac16a0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5519 +/- ##
==========================================
- Coverage 61.43% 61.42% -0.01%
==========================================
Files 312 312
Lines 11103 11103
Branches 762 762
==========================================
- Hits 6821 6820 -1
- Misses 4282 4283 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RemoteFileUtil did not preserve element ordering wich was assumed in the FileDownloadDoFn
Pane information was not propagated