fix: targeting key serialization fix #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziodemaria
requested review from
mfranberg,
vahidlazio,
nicklasl,
DennisPersson and
nickybondarenko
as code owners
nicklasl
reviewed
Feb 13, 2024
Comment on lines
+99
to
+106
| func processTargetingKey(evalCtx openfeature.FlattenedContext) openfeature.FlattenedContext { | ||
| newEvalContext := openfeature.FlattenedContext{} | ||
| newEvalContext = evalCtx | ||
| if targetingKey, exists := evalCtx["targetingKey"]; exists { | ||
| newEvalContext["targeting_key"] = targetingKey | ||
| } | ||
| return newEvalContext | ||
| } |
There was a problem hiding this comment.
Can't say much about the Go specifics but looks to do the right thing.
Would love to see a unit test for this!
nicklasl
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GO SDK flattens the context using targetingKey as key for the targeting key value in the context.
Other SDK pass the (non-flattened) EvaluationContext object to the Provider and let the latter decide how to encode the context. We might want to investigate more why the implementation in GO differs in these regards.
In the meantime, this fix allows to keep backwards compatibility and inter-operability between different backends at the cost of sending duplicate data. Note that the user can always set
targeting_keyas an attribute