From 6eaf131575109c86b7c93d471bedd09bfdb0a7ad Mon Sep 17 00:00:00 2001
From: Jeremy Landis <jeremylandis@hotmail.com>
Date: Sat, 21 Sep 2024 00:09:44 -0400
Subject: [PATCH] [drop] Remove support for maven 3.6 plugin as cannot support
 any longer

The support this was to show fixed isn't supported by maven any longer for many, many years.  In order to get to doxia we need to drop this support.
---
 pom.xml                                       |   2 -
 src/it/MFINDBUGS-145/invoker.properties       |  20 ---
 src/it/MFINDBUGS-145/pom.xml                  | 136 ------------------
 .../it/mfindbugs145/App.java                  |  32 -----
 src/it/MFINDBUGS-145/src/site/site.xml        |  53 -------
 src/it/MFINDBUGS-145/verify.groovy            |  41 ------
 6 files changed, 284 deletions(-)
 delete mode 100644 src/it/MFINDBUGS-145/invoker.properties
 delete mode 100644 src/it/MFINDBUGS-145/pom.xml
 delete mode 100644 src/it/MFINDBUGS-145/src/main/java/org/codehaus/mojo/spotbugsmavenplugin/it/mfindbugs145/App.java
 delete mode 100644 src/it/MFINDBUGS-145/src/site/site.xml
 delete mode 100644 src/it/MFINDBUGS-145/verify.groovy

diff --git a/pom.xml b/pom.xml
index c2fa2e3b..0d371296 100644
--- a/pom.xml
+++ b/pom.xml
@@ -209,8 +209,6 @@
         <pluginPluginVersion>3.15.0</pluginPluginVersion>
         <scmPluginVersion>2.1.0</scmPluginVersion>
         <sitePluginVersion>3.12.1</sitePluginVersion>
-        <!-- Site Plugin for MFINDBUGS-145 (breaks on newer jdks, revisit this on spotbugs 5.0.x and simply drop the old support) -->
-        <sitePlugin36Version>3.6</sitePlugin36Version>
         <versionsPluginVersion>2.17.1</versionsPluginVersion>
 
         <spotbugsTestDebug>false</spotbugsTestDebug>
diff --git a/src/it/MFINDBUGS-145/invoker.properties b/src/it/MFINDBUGS-145/invoker.properties
deleted file mode 100644
index af4f3cdc..00000000
--- a/src/it/MFINDBUGS-145/invoker.properties
+++ /dev/null
@@ -1,20 +0,0 @@
-#
-# Copyright 2005-2023 the original author or authors.
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     https://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-invoker.goals = clean compile site
-
-# The expected result of the build, possible values are "success" (default) and "failure"
-invoker.buildResult = success
diff --git a/src/it/MFINDBUGS-145/pom.xml b/src/it/MFINDBUGS-145/pom.xml
deleted file mode 100644
index 0910d3ab..00000000
--- a/src/it/MFINDBUGS-145/pom.xml
+++ /dev/null
@@ -1,136 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
-
-    Copyright 2005-2024 the original author or authors.
-
-    Licensed under the Apache License, Version 2.0 (the "License");
-    you may not use this file except in compliance with the License.
-    You may obtain a copy of the License at
-
-        https://www.apache.org/licenses/LICENSE-2.0
-
-    Unless required by applicable law or agreed to in writing, software
-    distributed under the License is distributed on an "AS IS" BASIS,
-    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-    See the License for the specific language governing permissions and
-    limitations under the License.
-
--->
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
-  <modelVersion>4.0.0</modelVersion>
-
-  <!-- Parent is disabled on purpose
-  <parent>
-    <groupId>spotbugs-maven-plugin.it</groupId>
-    <artifactId>common</artifactId>
-    <version>testing</version>
-    <relativePath>../common.xml</relativePath>
-  </parent>
-  -->
-
-  <groupId>spotbugs-maven-plugin.it</groupId>
-  <artifactId>MFINDBUGS-145</artifactId>
-  <version>testing</version>
-  <packaging>jar</packaging>
-
-  <name>MFINDBUGS-145</name>
-  <url>http://maven.apache.org</url>
-
-  <properties>
-    <!-- These two are used due to old compiler on maven 3.6.3 GHA build -->
-    <maven.compiler.source>8</maven.compiler.source>
-    <maven.compiler.target>8</maven.compiler.target>
-
-    <maven.compiler.release>8</maven.compiler.release>
-
-    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-    <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
-  </properties>
-
-  <build>
-    <plugins>
-      <plugin>
-        <groupId>org.apache.maven.plugins</groupId>
-        <artifactId>maven-site-plugin</artifactId>
-        <version>@sitePlugin36Version@</version>
-        <configuration>
-          <!-- MFINDBUGS-145 indicates this setup although this is obsolete and should not be used -->
-          <reportPlugins>
-            <plugin>
-              <groupId>org.apache.maven.plugins</groupId>
-              <artifactId>maven-jxr-plugin</artifactId>
-              <version>@jxrPluginVersion@</version>
-            </plugin>
-            <plugin>
-              <groupId>com.github.spotbugs</groupId>
-              <artifactId>spotbugs-maven-plugin</artifactId>
-              <version>@pom.version@</version>
-            </plugin>
-          </reportPlugins>
-        </configuration>
-        <!-- Jdk14 and above requires doxia be upgraded and allows test to still use old site otherwise test must be deleted -->
-        <dependencies>
-          <dependency>
-            <groupId>org.apache.maven.doxia</groupId>
-            <artifactId>doxia-sink-api</artifactId>
-            <version>@doxiaVersion@</version>
-          </dependency>
-          <dependency>
-            <groupId>org.apache.maven.doxia</groupId>
-            <artifactId>doxia-module-xhtml</artifactId>
-            <version>@doxiaVersion@</version>
-          </dependency>
-          <dependency>
-            <groupId>org.apache.maven.doxia</groupId>
-            <artifactId>doxia-module-apt</artifactId>
-            <version>@doxiaVersion@</version>
-          </dependency>
-          <dependency>
-            <groupId>org.apache.maven.doxia</groupId>
-            <artifactId>doxia-module-xdoc</artifactId>
-            <version>@doxiaVersion@</version>
-          </dependency>
-          <dependency>
-            <groupId>org.apache.maven.doxia</groupId>
-            <artifactId>doxia-module-fml</artifactId>
-            <version>@doxiaVersion@</version>
-          </dependency>
-          <dependency>
-            <groupId>org.apache.maven.doxia</groupId>
-            <artifactId>doxia-module-markdown</artifactId>
-            <version>@doxiaVersion@</version>
-          </dependency>
-          <dependency>
-            <groupId>org.apache.maven.doxia</groupId>
-            <artifactId>doxia-decoration-model</artifactId>
-            <version>@doxiaSiteToolsVersion@</version>
-          </dependency>
-          <dependency>
-            <groupId>org.apache.maven.doxia</groupId>
-            <artifactId>doxia-site-renderer</artifactId>
-            <version>@doxiaSiteToolsVersion@</version>
-          </dependency>
-          <dependency>
-            <groupId>org.apache.maven.doxia</groupId>
-            <artifactId>doxia-integration-tools</artifactId>
-            <version>@doxiaSiteToolsVersion@</version>
-          </dependency>
-        </dependencies>
-      </plugin>
-    </plugins>
-  </build>
-
-  <reporting>
-    <plugins>
-      <!-- Uncomment to generate JXR links and to stop this test from failing.
-      <plugin>
-        <groupId>org.apache.maven.plugins</groupId>
-        <artifactId>maven-jxr-plugin</artifactId>
-        <version>@jxrPluginVersion@</version>
-      </plugin>
-      -->
-    </plugins>
-  </reporting>
-
-</project>
diff --git a/src/it/MFINDBUGS-145/src/main/java/org/codehaus/mojo/spotbugsmavenplugin/it/mfindbugs145/App.java b/src/it/MFINDBUGS-145/src/main/java/org/codehaus/mojo/spotbugsmavenplugin/it/mfindbugs145/App.java
deleted file mode 100644
index 8aa239ec..00000000
--- a/src/it/MFINDBUGS-145/src/main/java/org/codehaus/mojo/spotbugsmavenplugin/it/mfindbugs145/App.java
+++ /dev/null
@@ -1,32 +0,0 @@
-/*
- * Copyright 2005-2023 the original author or authors.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     https://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.codehaus.mojo.spotbugsmavenplugin.it.mfindbugs145;
-
-/**
- * Hello world!
- *
- */
-public class App implements Cloneable {
-
-    public static void main(String[] args) {
-        System.out.println("Hello World!");
-    }
-
-    public Object clone() {
-        return null; // Does not call 'super.clone()'.
-    }
-
-}
diff --git a/src/it/MFINDBUGS-145/src/site/site.xml b/src/it/MFINDBUGS-145/src/site/site.xml
deleted file mode 100644
index c44c6805..00000000
--- a/src/it/MFINDBUGS-145/src/site/site.xml
+++ /dev/null
@@ -1,53 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
-
-    Copyright 2005-2023 the original author or authors.
-
-    Licensed under the Apache License, Version 2.0 (the "License");
-    you may not use this file except in compliance with the License.
-    You may obtain a copy of the License at
-
-        https://www.apache.org/licenses/LICENSE-2.0
-
-    Unless required by applicable law or agreed to in writing, software
-    distributed under the License is distributed on an "AS IS" BASIS,
-    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-    See the License for the specific language governing permissions and
-    limitations under the License.
-
--->
-<project xmlns="http://maven.apache.org/DECORATION/1.8.0"
-    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/DECORATION/1.8.1 https://maven.apache.org/xsd/decoration-1.8.1.xsd"
-    name="SpotBugs Maven Plugin">
-
-  <bannerLeft>
-    <name>SpotBugs Maven Plugin</name>
-  </bannerLeft>
-
-  <skin>
-    <groupId>org.apache.maven.skins</groupId>
-    <artifactId>maven-fluido-skin</artifactId>
-    <version>1.12.0</version>
-  </skin>
-
-  <custom>
-    <fluidoSkin>
-      <topBarEnabled>false</topBarEnabled>
-      <sideBarEnabled>false</sideBarEnabled>
-      <breadcrumbDivider>»</breadcrumbDivider>
-      <gitHub>
-        <projectId>spotbugs/spotbugs-maven-plugin</projectId>
-        <ribbonOrientation>right</ribbonOrientation>
-        <ribbonColor>red</ribbonColor>
-      </gitHub>
-      <ohloh>
-        <projectId>spotbugs-maven-plugin</projectId>
-        <widget>thin-badge</widget>
-      </ohloh>
-    </fluidoSkin>
-  </custom>
-
-  <publishDate format="yyyy-MM-dd" position="right"/>
-  <version position="right"/>
-
-</project>
diff --git a/src/it/MFINDBUGS-145/verify.groovy b/src/it/MFINDBUGS-145/verify.groovy
deleted file mode 100644
index 1b2f010a..00000000
--- a/src/it/MFINDBUGS-145/verify.groovy
+++ /dev/null
@@ -1,41 +0,0 @@
-/*
- * Copyright 2005-2023 the original author or authors.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     https://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-import java.io.File;
-import java.io.IOException;
-import java.io.FileNotFoundException;
-import java.nio.charset.StandardCharsets;
-import java.nio.file.Files;
-import java.nio.file.Path;
-
-String[] paths = [ "target/site/spotbugs.html", "target/site/xref/index.html" ]
-
-// Spotbugs and JXR reports
-for (String path : paths) {
-    File file = new File(basedir, path)
-    System.out.println("Checking for existence of " + file)
-    if (!file.isFile()) {
-        throw new FileNotFoundException("Missing: " + file.getAbsolutePath())
-    }
-}
-
-File report = new File(basedir, "target/site/spotbugs.html")
-String content = new String(Files.readAllBytes(report.toPath()), StandardCharsets.UTF_8)
-if (content.indexOf("<a href=\"./xref/org/codehaus/mojo/spotbugsmavenplugin/it/mfindbugs145/App.html#L29\">") < 0) {
-    throw new IOException("XRef link not generated.")
-}
-
-return true