Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: print report to console when reporting is not specified (#172) #363

Closed
wants to merge 3 commits into from
Closed

feat: print report to console when reporting is not specified (#172) #363

wants to merge 3 commits into from

Conversation

blzsaa
Copy link

@blzsaa blzsaa commented Oct 14, 2020

Possible solution for #172 print to console

jscancella
jscancella previously approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@jscancella jscancella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jscancella
Copy link
Contributor

@KengoTODA thoughts on this?

@KengoTODA KengoTODA mentioned this pull request Jul 21, 2021
Closed
@KengoTODA
Copy link
Member

@jscancella sorry for my late response.

this PR breaks backward compatibility, so I wanna release this as a part of v5 release.
Could you review and merge #555 first? Then we can release v5.0.0-beta1 with this feature.

@KengoTODA KengoTODA changed the base branch from master to beta September 16, 2021 12:18
KengoTODA added a commit that referenced this pull request Sep 16, 2021
@KengoTODA
feat!: print report to console when reporting is not specified
c5c61b8 
close #363
close #172
@KengoTODA KengoTODA mentioned this pull request Sep 16, 2021
Merged
KengoTODA added a commit that referenced this pull request Sep 17, 2021
@KengoTODA
feat!: print report to console when reporting is not specified
13565c5 
close #363
close #172
KengoTODA added a commit that referenced this pull request Sep 17, 2021
@KengoTODA
feat: print report to console when reporting is not specified
b78a1b3 
close #363
close #172

BREAKING CHANGE: Behavior without report config has been changed
from XML to console
@github-actions
Copy link

🎉 This issue has been resolved in version 5.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@KengoTODA
Copy link
Member

I've merged these changes to the beta branch manually. Thanks for your contribution!

@KengoTODA KengoTODA closed this Sep 17, 2021
@github-actions
Copy link

github-actions bot commented Dec 6, 2021

🎉 This issue has been resolved in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jscancella jscancella jscancella left review comments

Assignees
No one assigned
Labels
released on @beta released
Projects
None yet
Milestone
v5: Next Major Update with breaking c...
Development

Successfully merging this pull request may close these issues.
3 participants
@blzsaa @jscancella @KengoTODA