Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not working in 1.18, since deployment API version deprecation not handling #486

Closed
panpan0000 opened this issue Sep 21, 2022 · 2 comments · Fixed by #487
Closed

not working in 1.18, since deployment API version deprecation not handling #486

panpan0000 opened this issue Sep 21, 2022 · 2 comments · Fixed by #487

Comments

@panpan0000
Copy link
Contributor

panpan0000 commented Sep 21, 2022

Expected behaviour

The version handling is not accurate.
in charts/redisoperator/templates/_versions.tpl

{{- define "common.capabilities.deployment.apiVersion" -}}
{{- if semverCompare ">=1.19-0" .Capabilities.KubeVersion.GitVersion -}}
{{- print "apps/v1" -}}

the starting point should be 1.16 instead of 1.19.
#487 is created to fix it

per https://kubernetes.io/docs/reference/using-api/deprecation-guide/

The extensions/v1beta1, apps/v1beta1, and apps/v1beta2 API versions of Deployment are no longer served as of v1.16.

Actual behaviour

What is happening? Are all the pieces created? Can you access to the service?

Steps to reproduce the behaviour

Describe step by step what you've have done to get to this point

Environment

How are the pieces configured?

  • Redis Operator version
  • Kubernetes version
  • Kubernetes configuration used (eg: Is RBAC active?)

Logs

Please, add the debugging logs. In order to be able to gather them, add -debug flag when running the operator.

@ese
Copy link
Member

ese commented Sep 21, 2022

Due the kubernetes APIs we use internally in redis-operator it only supports kubernetes >= 1.21 so we could remove this checks in the chart and use directly apps/v1 API

@panpan0000
Copy link
Contributor Author

panpan0000 commented Sep 22, 2022

ok, I've updated my Pull Request.
But actually, after I force deploy redis-operator on my OLD 1.18.20, redis works fine without error , so far so good. :-)

@ese ese closed this as completed in #487 Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants