You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
redis-operator should allow users to specify the APIVersion to use for PersistentVolumeClaim through the field Spec.Redis.Storage.PersistentVolumeClaim.apiVersion exposed in the CRD.
Actual behaviour
We noticed that although the field Spec.Redis.Storage.PersistentVolumeClaim.apiVersion in the CR allows users to specify different API versions for Persistent Volume Claim, the field does not get used when creating the PVC for the statefulSet. As shown in the code here, the APIVersion is hardcoded as v1.
This may cause problems in the future when PersistentVolumeClaim has other versions than v1.
Steps to reproduce the behaviour
Deploy redis-operator
Deploy redis failover with Spec.Redis.Storage.PersistentVolumeClaim.apiVersion set to v2
Expected behaviour
redis-operator should allow users to specify the APIVersion to use for PersistentVolumeClaim through the field
Spec.Redis.Storage.PersistentVolumeClaim.apiVersion
exposed in the CRD.Actual behaviour
We noticed that although the field
Spec.Redis.Storage.PersistentVolumeClaim.apiVersion
in the CR allows users to specify different API versions for Persistent Volume Claim, the field does not get used when creating the PVC for the statefulSet. As shown in the code here, the APIVersion is hardcoded asv1
.This may cause problems in the future when PersistentVolumeClaim has other versions than
v1
.Steps to reproduce the behaviour
Spec.Redis.Storage.PersistentVolumeClaim.apiVersion
set tov2
Environment
How are the pieces configured?
quay.io/spotahome/redis-operator:v1.1.0
Fix
A possible improvement is to change the line at
redis-operator/operator/redisfailover/service/generator.go
Line 347 in 6e08a31
The text was updated successfully, but these errors were encountered: