-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for creating PodMonitor or ServiceMonitor #383
Comments
This issue is stale because it has been open for 45 days with no activity. |
Not stale |
This issue is stale because it has been open for 45 days with no activity. |
Bump |
This issue is stale because it has been open for 45 days with no activity. |
bump |
It would be great count with the feature if you want to make a PR :) @sagikazarmark |
This was closed by error, I'd say. @ese this feature request is regarding ServiceMonitors on the pods managed by the operator, not for the operator itself. |
Indeed, I added it to the referenced PR by accident. |
Resubmitted the issue, since I can't reopen it. I'll send a PR when I get there. |
Expected behaviour
Create PodMonitor/ServiceMonitor object for Redis and Sentinel.
Actual behaviour
Prometheus exporters are integrated into the RedisFailover CRD, but they still require PodMonitors or ServiceMonitors.
Proposed solution
Allow creating PodMonitor or ServiceMonitor resources along with exporters. For example:
Additional details
I'd be happy to draft a PR if you like the idea.
The text was updated successfully, but these errors were encountered: