feat: added --sc4s-version option #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdoroszko-splunk
requested review from
mbruzda-splunk and
mkolasinski-splunk
|
CLA Assistant Lite bot CLA Assistant Lite bot All contributors have signed the COC ✍️ ✅ |
|
CLA Assistant Lite bot: All contributors have NOT signed the CLA Document I have read the CLA Document and I hereby accept the CLA You can retrigger this bot by commenting recheck in this Pull Request |
|
I have read the Code of Conduct and I hereby accept the Terms |
|
I have read the CLA Document and I hereby accept the CLA |
mbruzda-splunk
previously approved these changes
Nov 24, 2023
mkolasinski-splunk
previously approved these changes
Nov 24, 2023
artemrys
reviewed
Nov 24, 2023
kdoroszko-splunk
dismissed stale reviews from mkolasinski-splunk and mbruzda-splunk
via
680621e
kdoroszko-splunk
requested review from
artemrys,
mbruzda-splunk and
mkolasinski-splunk
artemrys
reviewed
Nov 24, 2023
| try: | ||
| request.fixturenames.append(splunk_fixture) | ||
| splunk_info = request.getfixturevalue(splunk_fixture) | ||
| except Exception as e: |
There was a problem hiding this comment.
Ideally it should have a simple unit test covering this logic but I am fine moving forward with this PR.
artemrys
approved these changes
Nov 24, 2023
|
🎉 This PR is included in version 5.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --sc4s-version was the only parameter left not defined. Change was made to go from exporting its value to option in psa execution while executing local tests.