Prevent multiple calls to !stop or the use of it during backup pause #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent spectator/unteamed from calling !stop
PhlexPlexico
approved these changes
Sep 27, 2022
Apfelwurm
pushed a commit
to Lan2Play/get5
that referenced
this pull request
Oct 19, 2022
…plewis#887) Prevent multiple calls to !stop or the use of it during backup pause Prevent spectator/unteamed from calling !stop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If players spam
!stopduring a live round, the game restores to the beginning of the current round, which does not change the game-state from live, meaning successive calls to!stopmight trigger double restores, which messes up the game state. This prevents this from happening.We also don't want to be able to call
!stopwhile the game is still pending unpause from a restore.Edit: Also prevents spectators from calling
!stop.