Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First kills should be per round, not per team #660

Closed
redismx opened this issue Apr 9, 2021 · 1 comment · Fixed by #818
Closed

First kills should be per round, not per team #660

redismx opened this issue Apr 9, 2021 · 1 comment · Fixed by #818

Comments

@redismx
Copy link
Contributor

redismx commented Apr 9, 2021

The current stats of first kills measure it by team, which means that each round can have 2 first kills (one for each team), which is not quite what tournament organizers or platforms like HLTV use. Instead, the first kill is per round, i.e if it's 5v5 and team A kills someone from team B, if team B kills someone from team A it should not count a first kill for team A.

This might be a breaking change for those that are relying on it working this way, especially considering that this was introduced almost 5 years ago, so perhaps instead of replacing how the first kills work, we could introduce a new stat called opening kills, that can only be attributed once for a round.

@splewis
Copy link
Owner

splewis commented Apr 20, 2021

I agree with you, this should be changed.

As far as being a breaking change: I'm okay with breaking here, and will make sure it's documented in the release changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants