Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Podman #236

Closed
vchandela opened this issue Aug 30, 2024 · 2 comments · Fixed by #253
Closed

Add support for Podman #236

vchandela opened this issue Aug 30, 2024 · 2 comments · Fixed by #253

Comments

@vchandela
Copy link
Collaborator

vchandela commented Aug 30, 2024

  • Currently, some tests are dependent on Docker and fail otherwise.
  • We need some env var or flag to signal the tests that it's in Podman mode and have those tests succeed in such cases.
  • This is a possible barrier to entry especially to contributors who are on Linux and have Podman.

Steps to complete this issue:

  • Run mage test
  • You'll find I believe 6 tests that fail due to expecting the Docker socket file
  • Start figuring out a way to make that work, and start by making 1 test work with Podman
  • Repeat.
@purplefox
Copy link
Contributor

We need some env var or flag to signal the tests that it's in Podman mode and have those tests succeed in such cases.

Instead of env var, perhaps you could try to connect to podman/docker, and if you get an error that you cannot connect try the other one?

@vchandela
Copy link
Collaborator Author

We need some env var or flag to signal the tests that it's in Podman mode and have those tests succeed in such cases.

Instead of env var, perhaps you could try to connect to podman/docker, and if you get an error that you cannot connect try the other one?

makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants