Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canonicalizing VarBin array shouldn't cast to Ut8View #1143

Closed
robert3005 opened this issue Oct 28, 2024 · 2 comments · Fixed by #1145
Closed

Canonicalizing VarBin array shouldn't cast to Ut8View #1143

robert3005 opened this issue Oct 28, 2024 · 2 comments · Fixed by #1145

Comments

@robert3005
Copy link
Member

https://github.com/spiraldb/vortex/blob/develop/vortex-array/src/array/varbin/flatten.rs#L14 should cast depending on dtype
@a10y
Copy link
Contributor

a10y commented Oct 28, 2024

Gah, good catch

a10y added a commit that referenced this issue Oct 28, 2024
@a10y
fix: VarBinArray into_canonical dtype erasure (#1143)
737a3c9
@a10y a10y mentioned this issue Oct 28, 2024
Merged
@a10y
Copy link
Contributor

a10y commented Oct 28, 2024

#1145 should fix it

a10y added a commit that referenced this issue Oct 28, 2024
@a10y
fix: VarBinArray into_canonical dtype erasure (#1143) (#1145)
bdfcbd6 
Fixes #1143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: VarBinArray into_canonical dtype erasure (#1143) spiraldb/vortex
2 participants
@a10y @robert3005