Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve take performance on RunEndArray #803

Closed
a10y opened this issue Sep 13, 2024 · 3 comments
Closed

Improve take performance on RunEndArray #803

a10y opened this issue Sep 13, 2024 · 3 comments

Comments

@a10y
Copy link
Contributor

a10y commented Sep 13, 2024

Currently it calls find_physical_index in a hot loop. For dense takes, this can be quite a lot of overhead.

image

@robert3005
Copy link
Member

robert3005 commented Sep 13, 2024

FWIW I think we should have search_sorted for numerical arrays that just casts to u64/usize and avoids creating scalars. #795

@robert3005
Copy link
Member

Another thing would be to update our search_sorted to use the algorithm from latest rust std lib which is said to be 20-30% faster. Doubt we will have comparable speed up but likely there will be some gain

@a10y
Copy link
Contributor Author

a10y commented Sep 20, 2024

This was handled in a combo of #840 + #851

@a10y a10y closed this as completed Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants