Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FoR encoding should convert to unsinged variant of the original type #39

Open
robert3005 opened this issue Jun 21, 2024 · 1 comment
Open

Comments

@robert3005
Copy link
Member

In Vortex we have an issue where FoR arrays might no longer be sorted after compression spiraldb/vortex#400. In vortex it makes sense to try to find a different compressor in cases where FoR encoding would overflow. We could consider doing the same here since those values will not bitpack well

@robert3005
Copy link
Member Author

Everything can continue to behave as expected if the array after for encoding is converted to unsigned variant of the original type.

@robert3005 robert3005 changed the title Consider restricting FoR encoding to arrays where it will not overflow subtraction FoR encoding should convert to unsinged variant of the original type Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant