Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depreciated Code Dependency in Merge Checks #1018

Closed
a-angeles13 opened this issue Apr 23, 2022 · 1 comment
Closed

Depreciated Code Dependency in Merge Checks #1018

a-angeles13 opened this issue Apr 23, 2022 · 1 comment

Comments

@a-angeles13
Copy link

Noted in my comment in pull request #1016.

The check tests (3.7, minimal, postgresql; 3.7, minimal, mariadb; 3.9, minimal, sqlite; 3.10, minimal, sqlite) are failing due to depreciation in Werkzeug 2.1

Specifically, self.local.ident_func in line 215 of <test_path>/werkzeug/local.py is now depreciated and will not work in Python versions 3.7+. This was noted in a warning on line 34 of test of 3.7, minimal, postgresql in a previously successful merge. link.

I suggest that the merge check test suite be prioritized because any future pull requests will be blocked under any Werkzeug 2.1+.

@almet
Copy link
Member

almet commented Apr 23, 2022

Hey, thanks for your input ! We've discussed this in #1015 and I think it should be solved when we merge it :-)

@almet almet closed this as completed Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants