Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline Template tags should support SemVer #5569

Closed
smithhannahm opened this issue Mar 13, 2020 · 8 comments · May be fixed by spinnaker/front50#993
Closed

Pipeline Template tags should support SemVer #5569

smithhannahm opened this issue Mar 13, 2020 · 8 comments · May be fixed by spinnaker/front50#993

Comments

@smithhannahm
Copy link

Issue Summary:

When saving a Pipeline Template with tags, only certain tags are valid. We would like to tag our Pipeline Templates with SemVer, to allow developers to pin pipeline version.

Feature Area:

Managed Pipeline Templates v2
Spin CLI v1.14.0

Description:

Pipeline Template may be saved with a tag. I would expect that functionality to allow for any string, or at least any alphanumeric string. However, it only allows tagging with a small list of approved tags, and there is little to no documentation on what those tags are.

I would like to be able to tag with any string, especially SemVer. This will allow us to push updates to these pipelines, while allowing consuming teams to update at their own pace.

Additionally, right now there is no error message produced in the Spin CLI if you try to save a template with an invalid tag - it just doesn't save the pipeline. Nor is there any indication in the Spin CLI help that --tags only takes a certain set of values, much less what those values might be.

Steps to Reproduce:

Attempt to save a valid pipeline template using the tags flag with SemVer:

spin pipeline-template save --file pipeline.json --tag v0.1.0

It will say that it saved successfully, but no template will be saved.

Additional Details:

The code in question seems to be here.

@spinnakerbot
Copy link

This issue hasn't been updated in 45 days, so we are tagging it as 'stale'. If you want to remove this label, comment:

@spinnakerbot remove-label stale

@spinnakerbot
Copy link

This issue is tagged as 'stale' and hasn't been updated in 45 days, so we are tagging it as 'to-be-closed'. It will be closed in 45 days unless updates are made. If you want to remove this label, comment:

@spinnakerbot remove-label to-be-closed

@spinnakerbot
Copy link

This issue is tagged as 'stale' and hasn't been updated in 45 days, so we are tagging it as 'to-be-closed'. It will be closed in 45 days unless updates are made. If you want to remove this label, comment:

@spinnakerbot remove-label to-be-closed

@dbrougham
Copy link

@spinnakerbot remove-label to-be-closed

@alyssahardy
Copy link

This would make pipeline templates more robust. I would be very interested in this feature as well.

@spinnakerbot
Copy link

This issue is tagged as 'stale' and hasn't been updated in 45 days, so we are tagging it as 'to-be-closed'. It will be closed in 45 days unless updates are made. If you want to remove this label, comment:

@spinnakerbot remove-label to-be-closed

@micnncim
Copy link
Member

@spinnakerbot remove-label to-be-closed

@spinnakerbot
Copy link

This issue is tagged as 'to-be-closed' and hasn't been updated in 45 days, so we are closing it. You can always reopen this issue if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants