Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The shim binary name could not be re-named #190

Open
Mossaka opened this issue Sep 18, 2024 · 2 comments
Open

The shim binary name could not be re-named #190

Mossaka opened this issue Sep 18, 2024 · 2 comments

Comments

@Mossaka
Copy link
Member

Mossaka commented Sep 18, 2024

Due to a design decision made by runwasi, the shim's binary name cannot be renamed, or otherwise it will error out. (see https://github.com/containerd/runwasi/blob/containerd-shim-wasm/v0.6.0/crates/containerd-shim-wasm/src/sandbox/cli.rs#L95-L98)

containerd/runwasi#671 should fix it and once runwasi releases a new version, we can update the spin shim.

@kate-goldenring
Copy link
Collaborator

The binary seems to fit the shim_cli convention: containerd-shim-spin-v2 right?

@Mossaka
Copy link
Member Author

Mossaka commented Sep 18, 2024

Ah yeah, sorry for the confusion! My intention with this issue was to inform others and provide a warning that the shim binary cannot be renamed. You are absolutely right that if you download the spin shim binary from our release page / or build it yourself, the binary name is the correct one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants