Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the use of ServiceName and EnableServiceLabel for telemetry #5652

Open
graceajibade opened this issue Nov 19, 2024 · 1 comment
Open
Labels
triage/in-progress Issue triage is in progress

Comments

@graceajibade
Copy link

graceajibade commented Nov 19, 2024

From the telemetry doc, there are some labels that accompany metrics, we would find it useful in our deployment to be able to set a custom label to distinguish different sets of spire-servers from each other.

To this end, we could enable the use of ServiceName and EnableServiceLabel (which is from go-metric config) in metrics.go, which would give the ability to optionally pass a ServiceName and enable that ServiceName to be turned to a label. Looking at go-metric's implementation, it looks like it always uses "service" as the label. It would be nice if we could get it to be some kind of custom label, for example support for global labels could be introduced in metrics.go.

I would be happy to implement this if it gets accepted.

@graceajibade graceajibade changed the title Enable to use of ServiceName and EnableServiceLabel for telemetry Enable the use of ServiceName and EnableServiceLabel for telemetry Nov 19, 2024
@amartinezfayo amartinezfayo added the triage/in-progress Issue triage is in progress label Nov 19, 2024
@sorindumitru
Copy link
Contributor

Some more details, this is to help with having multiple trust domains publish metrics to the same destination/namespace. Having the trust domain as a label makes it easier to use, rather than including it in the metric namespace.

I don't think anything else apart from the trust domain id/name is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/in-progress Issue triage is in progress
Projects
None yet
Development

No branches or pull requests

3 participants