Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve process for handling flaky tests #5590

Open
rturner3 opened this issue Oct 17, 2024 · 2 comments
Open

Improve process for handling flaky tests #5590

rturner3 opened this issue Oct 17, 2024 · 2 comments
Labels
priority/backlog Issue is approved and in the backlog

Comments

@rturner3
Copy link
Collaborator

A single flaky test currently causes the PR unit test status check to fail. This increases the latency to merge the PR because someone has to rerun the failed status check after the whole set of builds completes. Repeated failures of flaky tests on a PR makes this problem even worse.

While flaky tests are being analyzed and fixed, it would be good to have a way to prevent tests that are designated as flaky from failing PR status checks on a single failure. Some rough ideas:

  • Create a dedicated build for flaky tests. Tests could be marked flaky by adding Flaky in the test name so we can use go test -skip .*Flaky / go test -run .*Flaky to control when flaky tests are run.
  • Retry flaky tests in a dedicated build. This could use some existing merge queue solutions for GitHub, if it works for us, or a dedicated build we design
@rturner3 rturner3 added the priority/backlog Issue is approved and in the backlog label Oct 17, 2024
@edwbuck
Copy link
Contributor

edwbuck commented Nov 7, 2024

@rturner3 Some segregation of the flapping tests would be greatly appreciated. 👍

@sorindumitru
Copy link
Contributor

Could we also run the tests using -count X so they are run a couple of times? Slower test runs, but it increases the chance that we catch flaky tests when they are introduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/backlog Issue is approved and in the backlog
Projects
None yet
Development

No branches or pull requests

3 participants