Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken hyperlink in "Using Envoy with JWT-SVIDs" #205

Open
sanderson042 opened this issue Mar 3, 2021 · 0 comments · May be fixed by #215
Open

Broken hyperlink in "Using Envoy with JWT-SVIDs" #205

sanderson042 opened this issue Mar 3, 2021 · 0 comments · May be fixed by #215
Assignees

Comments

@sanderson042
Copy link
Contributor

The first sentence of the documentation page titled "Using Envoy with JWT-SVIDs" has a broken hyperlink to the page "Configure Envoy to Perform X.509 SVID Authentication" which results in a 404 error on GitHub. The same broken link occurs later on in the same page.

The page with the broken link is here on spiffe.io:
https://spiffe.io/docs/latest/microservices/envoy-jwt/readme/

In discussing this with @mchurichi he mentioned that the problem seems to be that the subdirectory k8s was omitted from the link:
https://github.com/spiffe/spire-tutorials/blob/master/k8s/envoy-x509 -> the good one
https://github.com/spiffe/spire-tutorials/blob/master/envoy-x509/ -> the not so good one

This page is imported into spiffe.io from the spire-tutorials repo on GitHub: https://github.com/spiffe/spire-tutorials/tree/master/k8s/envoy-jwt . The GitHub version of this page does not have the broken link. There is another issue with the import script (#193) that may or may not be related to this issue.

@mchurichi mchurichi self-assigned this Mar 30, 2021
@mchurichi mchurichi linked a pull request Apr 12, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants