Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export svg #33

Open
spiermar opened this issue Oct 17, 2015 · 2 comments
Open

export svg #33

spiermar opened this issue Oct 17, 2015 · 2 comments
Labels
enhancement New feature or request

Comments

@spiermar
Copy link
Owner

No description provided.

@spiermar spiermar added the enhancement New feature or request label Oct 18, 2015
@spiermar spiermar added this to the 1.2 milestone Feb 6, 2018
@spiermar spiermar removed this from the 3.1 milestone Oct 12, 2021
@kristoffSC
Copy link

kristoffSC commented Apr 4, 2023

Hi,
Was there any idea about how to implement this feature?
It would be a great thing to have.

The SVG tag created by this library seems to have the all data. What is missing is the callback methods that would handle "clicking" on frame adding the "interactive" feature to it. Something like the SVG from original flame-graph library have https://github.com/brendangregg/FlameGraph/blob/master/demos/cpu-mixedmode-flamegraph-java.svg?short_path=704339e

If there was an Idea for this feature, maybe I would be able to contribute :)

@spiermar
Copy link
Owner Author

spiermar commented Apr 4, 2023

@kristoffSC this is a feature I discussed with @brendangregg a while ago. The way I'm thinking about this now is that this should not be a feature of the d3 plugin, but the application using it, mostly because some features are highly customizable can change significantly from application to application. Also, a few notes on using SVG as an output format:

  1. Right now the plugin is generating an SVG, but that might not be the case in the future. HTML canvas was an option for example.
  2. The SVG, with all embedded JavaScript to add the "interactive" features is a bit awful and limited in functionality.
  3. It would also require a fairly large rewrite of the interactive functions just for that.

In the internal version of https://github.com/Netflix/flamescope, FlameCommander, we implemented a feature to download a self contained HTML file with the flame graph and all features. I could probably create an example based on that.

Also, @andreasgerstmayr implemented a flame graph HTML output for perf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants