Child block disappears after autosave

[ccchapman]

Bug Description

A newly created child block disappears after autosave.

Steps to reproduce

1. Create an entry
2. Add a Neo block at the root level
3. Add a child Neo block to that block
4. Populate field values on that child Neo block
5. Wait for the autosave to finish
6. Child Neo block disappears from screen

Expected behaviour

No response

Neo version

4.0.6

But we think we had the issue on 4.0.5 too.

Craft CMS version

4.8.0

What is the affected Neo field's propagation method?

"all" but the owner element is "none"

Does this issue involve templating, and if so, is eager-loading used?

This is not a templating issue

[ccchapman]

I have emailed in a screen recording of the issue in case any additional relevant details are observed.

[ccchapman]

We searched through Craft logs and found some errors which may or may not be relevant. These errors happened close to the times we have observed issues.

2024-03-05 08:58:16 [web.ERROR] [yii\web\HttpException:400] Invalid draft ID: 375
2024-03-05 08:33:36 [web.ERROR] [yii\web\HttpException:400] Invalid draft ID: 368

We have seen these types of requests for admin/actions/elements/recent-activity and admin/actions/elements/save-draft.

[ttempleton]

That is a pretty weird one, looking at the screen recording, since it doesn't even happen after the first edit of the child block.

If possible, could you please email the composer files and database backup, and we'll have a look.

[ccchapman]

That is a pretty weird one, looking at the screen recording, since it doesn't even happen after the first edit of the child block.

If possible, could you please email the composer files and database backup, and we'll have a look.

Thank you, Thomas. I have sent the files.

I have not been able to reproduced the issue myself. We have a user that has encountered it many times in the last two weeks.

[ttempleton]

Thanks for sending those. I'm unable to reproduce it either, so far. I'm guessing it's a timing issue with draft autosaves and Neo updating visible field layout elements, like #823. (Last I checked, updating of visible field layout elements for inline Matrix blocks in Craft 5 worked very similarly to how it currently works for Neo, so my comments in #823 are unfortunately irrelevant.)

Given that this issue involves the use of a child block UI element, a possible workaround is to remove the UI element, since it seems like the updating of visible field layout elements is causing the UI element contents to be reset.

[ccchapman]

Given that this issue involves the use of a child block UI element, a possible workaround is to remove the UI element, since it seems like the updating of visible field layout elements is causing the UI element contents to be reset.

Thank you for the suggestion. We will test removing the "Child Blocks" UI element from the block type field layout.

[ccchapman]

Could this be the same as #891?

[ttempleton]

I don't think that's the same since #891 only happened when saving as a new entry, not during autosave.

Recent changes could have potentially resolved this, though; have you had it happen recently?

[ccchapman]

Recent changes could have potentially resolved this, though; have you had it happen recently?

We have not seen it again; however, we still have the child blocks UI element removed.

[jesuismaxime]

I got something similar, when re-ordering to 'parent' blocks, their children got (reaaaally) mixup but since I have a condition (max. 2 blocks) on one of them, it prevent the save - still annoying since I can't reorder parent blocks (that act as sections in our layout builder).

Is there someone working on it?

(I update to the latest Craft and Neo version, still got the issue)

Here's a quick video of the bug:

Enregistrement.d.ecran.le.2024-08-05.a.14.07.58.mov

[ttempleton]

@jesuismaxime I can't tell from your video whether you've saved before or after the draft autosave. If it was before the autosave, could you please try saving after the autosave and let me know if that works as expected?

[jesuismaxime]

The error was caused by a manual save, if I resave, the duplicata increment.Le 8 août 2024 à 01:08, Thomas Templeton ***@***.***> a écrit : @jesuismaxime I can't tell from your video whether you've saved before or after the draft autosave. If it was before the autosave, could you please try saving after the autosave and let me know if that works as expected? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

[ttempleton]

I can't tell from your video whether your manual save was before or after the draft autosave. Or do you have Craft's autosaveDrafts setting set to false, or is the owner element of a type that does not autosave drafts?

[pc-erin]

Just for anyone else who encounters this: if it's a timing issue, you can sometimes replicate those easier by throttling your connection in the browser network tools.