Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entry Condition with custom fields not persisted #779

Closed
deeekay opened this issue Aug 24, 2023 · 2 comments
Closed

Entry Condition with custom fields not persisted #779

deeekay opened this issue Aug 24, 2023 · 2 comments

Comments

@deeekay
Copy link

deeekay commented Aug 24, 2023

Bug Description

Unexpected behaviour when trying to use custom fields for entry condition in neo blocks.

Steps to reproduce

  1. Select a Neo field block and click on "Advanced"
  2. Select "Add a rule" from "Entry Condition"
    --> Expected: All fields can be selected (under "Fields")
    --> Actual: Only default conditions can be selected
  3. Select any condition and click on "Add a rule" or on the previously added rule
    --> Any field can now be selected
  4. Add condition and save neo field
  5. Open neo field again and go to "Advanced" and the "Entry Condition" again
    --> Expected: previously added rule with custom field is still there
    --> Actual: previously added rule is gone
neo-field-bug.mov

Expected behaviour

No response

Neo version

3.8.6

Craft CMS version

4.5.1

What is the affected Neo field's propagation method?

No response

Does this issue involve templating, and if so, is eager-loading used?

This is not a templating issue

@ttempleton
Copy link
Contributor

It is currently expected that the field condition options would not appear. I'll have a look at why they start to appear, likely next week.

@ttempleton
Copy link
Contributor

As far as I can tell, this isn't possible for us to fix by removing the options from the condition builder without an extra event in Craft to help us out (Neo currently using an event when condition rule types are registered, in combination with a flag set in Neo when rendering the block type settings that we're unable to set when the condition builder is re-rendered after a condition is added).

Since it seems unreasonable to me for Craft to have changes made to it to fix one bug in one plugin, I'm going to close this and reopen #778, as that being implemented would make this issue obsolete anyway.

@ttempleton ttempleton closed this as not planned Won't fix, can't repro, duplicate, stale Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants