set pageurl through get_target_uri in StandaloneHTMLBuilder #9731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaoming
approved these changes
Feb 15, 2023
|
@AA-Turner This seems like a useful bug fix, if you have time to review it. Though I imagine also having a test would make it easier to merge, I do think this is causing real issues with canonical URLs. |
|
If there is anything I can do on my side to get this merged, please let me know. |
# Conflicts: # sphinx/builders/html/__init__.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject: set pageurl through get_target_uri in StandaloneHTMLBuilder
Feature or Bugfix
Purpose
Fixes #9730
Detail
Suggestion to fix #9730 by using
get_target_uri()to set the page URL instead of hard-coding the addition of file extension (out_suffix). The methodget_target_uri()is already re-defined byDirectoryHTMLBuilder, doing the right thing independently of the builder.