You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have a project which includes some C extensions, built in an isolated environment via PEP-517. This means that the source tree never has a compiled version of the C extensions in it, only the built wheel has those. This makes it impossible to import the package from the source root. When sphinxcontrib-towncrier runs "python -m towncrier" this automatically adds the current directory to the system path, resulting in a failure of towncrier to import the module. This can be fixed by telling Python to run the module isolated "python -Im towncrier ...". Would you consider supporting this paradigm, perhaps as a configurable option? I am happy to put together a PR if the proposal is acceptable.
Thanks.
The text was updated successfully, but these errors were encountered:
This does allow towncrier to run without error, but it also means that I can no longer get the package name as part of the output section title. I guess that I can live with that as an easy solution.
Would you consider supporting this paradigm, perhaps as a configurable option? I am happy to put together a PR if the proposal is acceptable.
I just realized that I never responded to this bit. I think a PR would be welcome. Do you foresee any substantial downsides in making this unconditional? If yes, we'd need a toggle. If no, there'd be no need for one.
My only ask is trying not to break the existing users of this extension, the most prominent ones being aiohttp, ansible-pylibssh, attrs and pip. The eventual PR would need to be tested against those projects. Consider this an acceptance test.
I have a project which includes some C extensions, built in an isolated environment via PEP-517. This means that the source tree never has a compiled version of the C extensions in it, only the built wheel has those. This makes it impossible to import the package from the source root. When sphinxcontrib-towncrier runs "python -m towncrier" this automatically adds the current directory to the system path, resulting in a failure of towncrier to import the module. This can be fixed by telling Python to run the module isolated "python -Im towncrier ...". Would you consider supporting this paradigm, perhaps as a configurable option? I am happy to put together a PR if the proposal is acceptable.
Thanks.
The text was updated successfully, but these errors were encountered: