-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tool.hatch.build.targets.wheel to fix pip install .
with Hatchling 1.19
#106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
force-pushed
the
fix-hatchling
branch
from
December 11, 2023 18:26
62aebe3
to
b3bb4c0
Compare
hugovk
force-pushed
the
fix-hatchling
branch
from
December 11, 2023 18:28
b3bb4c0
to
1da6e32
Compare
ofek
approved these changes
Dec 12, 2023
AlexWaygood
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
hugovk
commented
Dec 12, 2023
Thanks both! I'll release this right away so we can update pre-commit in various repos. |
This was referenced Dec 12, 2023
euri10
added a commit
to euri10/litestar
that referenced
this pull request
Dec 13, 2023
cofin
pushed a commit
to litestar-org/litestar
that referenced
this pull request
Dec 13, 2023
fix(ci): upgrade sphinx-lint (sphinx-contrib/sphinx-lint#106)
lengau
referenced
this pull request
in canonical/craftcraft
Dec 15, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [docs/sphinx-lint](https://togithub.com/sphinx-contrib/sphinx-lint) ([changelog](https://togithub.com/sphinx-contrib/sphinx-lint/releases)) | `==0.8.2` -> `==0.9.1` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/docs%2fsphinx-lint/0.9.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/docs%2fsphinx-lint/0.9.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/docs%2fsphinx-lint/0.8.2/0.9.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/docs%2fsphinx-lint/0.8.2/0.9.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>sphinx-contrib/sphinx-lint (docs/sphinx-lint)</summary> ### [`v0.9.1`](https://togithub.com/sphinx-contrib/sphinx-lint/releases/tag/v0.9.1) [Compare Source](https://togithub.com/sphinx-contrib/sphinx-lint/compare/v0.9.0...v0.9.1) #### What's Changed - Add `tool.hatch.build.targets.wheel` to fix `pip install .` with Hatchling 1.19 by [@​hugovk](https://togithub.com/hugovk) in [https://github.com/sphinx-contrib/sphinx-lint/pull/106](https://togithub.com/sphinx-contrib/sphinx-lint/pull/106) This fixes `ValueError: Unable to determine which files to ship inside the wheel using the following heuristics: [...]` when trying to `pip install .`, including via pre-commit. - Add tox for easy testing of multiple Python versions by [@​hugovk](https://togithub.com/hugovk) in [https://github.com/sphinx-contrib/sphinx-lint/pull/100](https://togithub.com/sphinx-contrib/sphinx-lint/pull/100) - Lint on GitHub Actions via pre-commit by [@​hugovk](https://togithub.com/hugovk) in [https://github.com/sphinx-contrib/sphinx-lint/pull/104](https://togithub.com/sphinx-contrib/sphinx-lint/pull/104) **Full Changelog**: sphinx-contrib/sphinx-lint@v0.9.0...v0.9.1 ### [`v0.9.0`](https://togithub.com/sphinx-contrib/sphinx-lint/releases/tag/v0.9.0) [Compare Source](https://togithub.com/sphinx-contrib/sphinx-lint/compare/v0.8.2...v0.9.0) #### What's Changed - Print error messages to stderr by [@​rffontenelle](https://togithub.com/rffontenelle) in [https://github.com/sphinx-contrib/sphinx-lint/pull/102](https://togithub.com/sphinx-contrib/sphinx-lint/pull/102) #### New Contributors - [@​rffontenelle](https://togithub.com/rffontenelle) made their first contribution in [https://github.com/sphinx-contrib/sphinx-lint/pull/102](https://togithub.com/sphinx-contrib/sphinx-lint/pull/102) **Full Changelog**: sphinx-contrib/sphinx-lint@v0.8.2...v0.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekend" in timezone Etc/UTC, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/canonical/craftcraft). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuOTMuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Hatchling 1.19:
PyPI install still work, but this does affect pre-commit installs, which uses
pip install .
from a Git clone.CI build of current
main
: https://github.com/sphinx-contrib/sphinx-lint/actions/runs/7171471394This is pypa/hatch#1113, and adding this fixes it: