-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hugo import from jekyll See #101 #1469
Conversation
This is pure gold! We should test this with a few Jekyll sites on both *nix and Windows, but this will be a big sell for Hugo. /cc @spf13 |
I tested this on OSX by converting the two first sites on http://jekyllrb.com/docs/sites/ It worked (almost) flawless. One question: The below site have images under /images. I have no idea what the Jekyll standard says about this, but for this particular case, the images doesn't get copied to /static. https://github.com/qrush/qrush.github.com As I said, not sure if this is correct or not. |
@bep Thank you for your thorough testing. Yes, I missed copy some files and folders. The Jekyll structure rule as below: I have added copyJekyllFilesAndFolders function to fix it, please check it again, thx! |
Yes, now it works great. One comment, though, re. below.
Also, isn't
|
@coderzh, awesome job with the importer! Just like @bep, this is pure gold! Thank you for your contribution. I have a big favour to ask you though. Since this is a significantly large contribution, please read http://discuss.gohugo.io/t/switching-to-apache-2-license/173 and sign there if you agree. We would like to switch from "SimPL-2.0" to "Apache License 2.0" in the near future (hopefully). Many thanks! |
@bep The reason why I chose And I have found another perfect theme in So I changed As the automated-deployments page said, rm .git folder in the theme folder after clone sounds like the official method? |
@anthonyfok Signed already, thx! |
c34118d
to
1dd7908
Compare
Just modified some code about Error Handling. |
Could you also fix the commit message in line with the guidelines? |
|
||
jekyllRoot, err := filepath.Abs(filepath.Clean(args[0])) | ||
if err != nil { | ||
jww.ERROR.Println("Path error:", args[0]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should return here. No point in going in with no Jekyll source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
9defa49
to
1bf1b4c
Compare
All done. |
usage: hugo import jekyll jekyll_root_path target_path Implemented: * Create new hugo site * Create config.yaml * Convert all markdown contents. * Copy all other files and folders to static Fixes gohugoio#101
I haven't tested it yet, but it looks great and I know users will be On Sun, Oct 4, 2015 at 7:17 AM coderzh [email protected] wrote:
|
Merged in 9a2f6c6 Real life testing will probably lead to more requirements, but this is a fantastic start. |
This is super. (And there's an existing path from Typepad to Jekyll, using https://github.com/koozie/typepad_to_jekyll , so this will be helpful for those making that transition). |
Love it! This is super exciting and is the final piece of the puzzle for getting me off Octopress. Great effort, thanks very much to all involved. 👏 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Issue #101
Implemented:
static