-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ReadDir function to list local files #1204
Conversation
Can you add a test for this? |
I honestly don't know how I would do that progammatically. At the moment all I can do is say that it has worked for me on both windows and linux with forward and backward slashes used in the path. |
@rustyoz: This looks fine, but as it is now it is possible to navigate outside the WorkDir. This may sound innocent, and it mostly is, but one could imagine a theme author doing something stupid. So some thightening of that issue would be nice. |
I have updated the commit to include a test for parent directory markers ".." which should prevent navigation outside of the working directory |
9394588
to
f951eb0
Compare
All good. It seems like the appveyor test failure was due to a missing newline of all things. |
Includes documentation.
Merged in 81e69c4 This is very useful. And thanks for taking the time to write some solid documentation. It's boring, but needed. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Adds functionality wanted by @Lynxiayel in this community post