Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check and deprecate the disable404, disableSitemap etc. #3345

Closed
bep opened this issue Apr 14, 2017 · 4 comments
Closed

Check and deprecate the disable404, disableSitemap etc. #3345

bep opened this issue Apr 14, 2017 · 4 comments
Assignees
Labels
Milestone

Comments

@bep
Copy link
Member

bep commented Apr 14, 2017

No description provided.

@bep bep added this to the v0.21 milestone Apr 14, 2017
@bep bep self-assigned this Apr 14, 2017
@digitalcraftsman
Copy link
Member

Just to be sure: you're deprecating this config options because the same can be achieved disableKinds as follows:

disableKinds = ["RSS", "sitemap", "robotsTXT", "404"]

@bep
Copy link
Member Author

bep commented Apr 15, 2017

Yes, those double settings are (or will be) a pain to maintain. The code is shattered with double ifs and double tests etc.

@digitalcraftsman
Copy link
Member

Thanks for the confirmation. And yes, the new approach is much cleaner.

@bep bep closed this as completed in 5794a26 May 10, 2017
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants