Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support themesDir option #1556

Closed
sebholstein opened this issue Nov 7, 2015 · 9 comments
Closed

Support themesDir option #1556

sebholstein opened this issue Nov 7, 2015 · 9 comments

Comments

@sebholstein
Copy link
Contributor

I would like to configure where my themes are located. Currently the "themes" dir name is hardcoded (path.go#L213) and not configurable. My proposal is to add a themesDir option (in addition to dataDir, staticDir, etc.):

themesDir: 'assets/docs/themes'
theme: 'myTheme'

In this case, hugo would use asset/docs/themes/myTheme as the theme folder.

@spf13
Copy link
Contributor

spf13 commented Nov 7, 2015

Great idea. Do you want to code it?

@sebholstein
Copy link
Contributor Author

I'm not familiar with the codebase but I will try :-)

@bep bep changed the title Proposal - Support themesDir option Support themesDir option Nov 7, 2015
@bep bep added the Enhancement label Nov 7, 2015
@AldenJole
Copy link

It seems like it might be more useful to just have a themePath option. Then I could use it like hugo server --themePath . --source exampleSite during theme development.

@spf13
Copy link
Contributor

spf13 commented Nov 29, 2015

@AldenJole I like that idea as well. Not sure which one is better. Probably yours, it's simpler. Is there a valid use case for the themeDir approach if we have themePath?

@AldenJole
Copy link

Eventually we might be able to replace the whole themeDir concept with themePath and then just put them in themes by convention. Then the config option would look like theme = "themes/<theme-name>". That would also give use the ability to specify remote themes, e.g., github projects.

@spf13
Copy link
Contributor

spf13 commented Nov 29, 2015

I agree. I like this much better.

Steve Francia
http://stevefrancia.com
http://spf13.com
http://twitter.com/spf13

On Sun, Nov 29, 2015 at 12:35 PM, Alden Jole [email protected]
wrote:

Eventually we might be able to replace the whole themeDir concept with
themePath and then just put them in themes by convention. Then the config
option would look like theme = "themes/". That would also
give use the ability to specify remote themes, e.g., github projects.


Reply to this email directly or view it on GitHub
#1556 (comment).

@AldenJole
Copy link

We might be able to figure out a reasonable way to parse the theme option to figure out if it's a path or not.

@moorereason
Copy link
Contributor

Fixed by #2817

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants