How does etcd play a role in cobra?

[ghost]

For example, how does etcd play a role in cobra?

https://github.com/spf13/cobra/blob/master/go.sum#L5

If this is a mistake, perhaps there are others and maybe go mod tidy would help?

If I'm completely off-base, sorry about that :)

[eparis]

@umarcor I'm not sure why it's in there....

[eparis]

Not that having the checksum of a random version of etcd hurts anything, I don't know it's listed. It wasn't ever part of cobra.

[umarcor]

@josdotso, @eparis, file go.sum contains all the dependencies of cobra, recursively. If you want to see which are the explicit/direct dependencies only, you need to look at go.mod. In order to understand why etcd is listed as an indirect dependency, you can use go mod graph:

# go mod graph | grep etcd
github.com/spf13/[email protected] github.com/coreos/[email protected]+incompatible
github.com/spf13/[email protected] github.com/coreos/[email protected]+incompatible

NOTE: alternatively, see 'Dependencies' tab in https://search.gocenter.io/github.com~2Fspf13~2Fcobra/info?version=v0.0.6-0.20190805155617-b80588d523ec

So, etcd and go-etcd seem to be dependencies of viper. These are/were listed in viper's go.mod. You will not find go-etcd in viper's master branch, because it was removed some months ago: spf13/viper@b5bf975#diff-37aff102a57d3d7b797f152915a6dc16

Precisely, PR #953 updates viper to v1.4.0, which will remove go-etcd from cobra's go.sum. See https://github.com/spf13/cobra/pull/953/files#diff-f949e2d81c8076ebbf8af38fcbb72c1f. BTW, @eparis, it'd be good if you could review and hopefully merge #953 (it fixes #938).

Ref spf13/viper#707

[ghost]

thank you!

[umarcor]

@josdotso, since it is answered, would you mind closing this issue?