-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
May 2021 release #1388
Comments
PRs that have been merged already for this release New features:
Bug fixes:
Maintainer Maintenance:
|
There is another fix for completion that I had forgotten to list, which properly handles the |
If you want this issue to track the content of the 1.2 release, I guess the following should be added, which were merged earlier but after the 1.1.3 release: New features:
Bug fixes:
Maintainer Maintenance:
|
What about #1146? I would love to use this. This is a great PR and fully backwards compatible. |
There is also value in merging the bash v2 for this release and not later: it would allow to use bash v2 by default for the automatic I will add tests to cobra-completion-testing to verify bash v2. |
I've added tests for bash v2 into cobra-completion-testing. Please see #1146 (comment). I hope this can help give some confidence in #1146 |
I'll take a look at #1146 this week - it's a beefy one, but looks worth the review and to get some nice completion features in |
As with most things, life got in the way and I wasn't able to review as much as I would have liked for this release. I'm planning to cut it hopefully soon (so we can at least get it out before we're too deep into June). Are there any other critical, "must get in now" PRs for this release? Thanks much all, always, for your patience! |
Thanks for the time you are able to put @jpmcb, it is greatly appreciated. I know it's a big ask but I wanted to mention that if we can get Bash completion v2 in this release (#1146), it can be used for the default |
To find the current list of vulnerable dependencies i ran the following command in the master branch go list -json -m all | docker run --rm -i sonatypecommunity/nancy:v1.0.22 sleuth --skip-update-check --no-color > vulnerabilities.txt In my opinion, these must be fixed in the release Result
|
#1146 has been merged. Going to look over any last second PRs and then will cut a release. |
https://github.com/spf13/cobra/releases/tag/v1.2.0 has landed! 🐍 🌠 |
Thank you @jpmcb |
Hi all - it's coming time for another release!
I will plan to cut a new 1.2.0 release sometime in the next week. We've merged a number of PRs already, but let's use this issue as a release tracker to get any necessary CVEs, critical issues, etc into the release!
The text was updated successfully, but these errors were encountered: