Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ValidArgsFunction receives nil Context #1263

Closed
lukasmalkmus opened this issue Oct 23, 2020 · 3 comments · Fixed by #1265
Closed

ValidArgsFunction receives nil Context #1263

lukasmalkmus opened this issue Oct 23, 2020 · 3 comments · Fixed by #1265

Comments

@lukasmalkmus
Copy link
Contributor

The ValidArgsFunction as well as the flag completion functions receive a *cobra.Command with a nil context.Context, even if the root command is executed with ExecuteCommand().
@marckhouzam
Copy link
Collaborator

@lukasmalkmus you are right. This was missed in the implementation. Feel like submitting a PR?

@lukasmalkmus
Copy link
Contributor Author

Will do. Do you think I should incorporate #1260 ?

@lukasmalkmus lukasmalkmus mentioned this issue Oct 25, 2020
Merged
@github-actions
Copy link

This issue is being marked as stale due to a long period of inactivity

@marckhouzam marckhouzam mentioned this issue Jan 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass context to completion
2 participants
@marckhouzam @lukasmalkmus