Unexpected behaviour from at least isEqual() when using UNIX epoch date (1970-01-01)

[wodow]

> spacetime('1970-01-01').isEqual('1970-01-01')
null
> spacetime('1970-01-02').isEqual('1970-01-02')
true
> spacetime('1970-01-02').isEqual('1970-01-01')
null
> spacetime('1970-01-01').isEqual('1970-01-02')
false

Should only return null when passed an invalid date?

[wodow]

Possible this affects other functions too, but have not yet checked.

[spencermountain]

hey Chris, thanks for the issue. I don't see any nulls, when I do this:

console.log(spacetime('1970-01-01').isEqual('1970-01-01'))
console.log(spacetime('1970-01-02').isEqual('1970-01-02'))
console.log(spacetime('1970-01-02').isEqual('1970-01-01'))
console.log(spacetime('1970-01-01').isEqual('1970-01-02'))

same thing in the repl - how did you produce this null response? You're right, that it should be a boolean always.
cheers

[wodow]

Are you testing on a more recent (dev?) version?

Here's a copy of Firefox's console output for your examples run on https://spacetime.how/

console.log(spacetime('1970-01-01').isEqual('1970-01-01'))
console.log(spacetime('1970-01-02').isEqual('1970-01-02'))
console.log(spacetime('1970-01-02').isEqual('1970-01-01'))
console.log(spacetime('1970-01-01').isEqual('1970-01-02'))
null debugger eval code:1:9
true debugger eval code:2:9
null debugger eval code:3:9
false debugger eval code:4:9
undefined
spacetime.version
"7.6.1"

[spencermountain]

weird - i'm seeing true/false in chrome/node/firefox

[wodow]

I get the nulls in Chrome/Chromium for me:

[wodow]

I've worked out why: we are both avoiding the obvious and also super pertinent elephant in the room, the timezone!

It only behaves this way with a GMT/UTC/London timezone, where the epoch is equal to zero.

getEpoch should allow for tmp.epoch being zero, but it only checks for truthiness:

spacetime/src/fns.js

Lines 59 to 71 in 0464eca

	export function getEpoch(tmp) {
	//support epoch
	if (typeof tmp === 'number') {
	return tmp
	}
	//suport date objects
	if (isDate(tmp)) {
	return tmp.getTime()
	}
	if (tmp.epoch) {
	return tmp.epoch
	}
	return null

[spencermountain]

haha, thank you. busted by pertinent elephant again.
Good catch. Happy to do a hotfix today, if I can.
cheers

[spencermountain]

released as 7.6.2
thanks for your help!