From c1ccf432467b9b26ea4413dbaa8818a7508f094f Mon Sep 17 00:00:00 2001
From: Peter Darton <peter.darton@i2group.com>
Date: Mon, 31 Jul 2023 12:03:34 +0100
Subject: [PATCH] Address review comments

---
 docs/circleci-recommendation.md | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/docs/circleci-recommendation.md b/docs/circleci-recommendation.md
index c9820c5..2e7b74c 100644
--- a/docs/circleci-recommendation.md
+++ b/docs/circleci-recommendation.md
@@ -5,7 +5,7 @@
 ```yml
 - run:
    command: |
-     vstest.console.exe ... --logger:"junit;LogFilePath=TestResults/test-result.xml;FailureBodyFormat=Verbose"
+     dotnet test ... --logger:"junit;LogFilePath=TestResults/test-result.xml;FailureBodyFormat=Verbose"
 - store_test_results:
    path: TestResults/
 ```
@@ -17,7 +17,8 @@ CircleCI uses just a few pieces of the JUnit XML report to generate the displaye
 Maintenance note:
 Findings as of July 20 2023.
  - Only data in a <testcase> element is shown.
- - The logger only puts console text in at the <testsuite> level so CircleCI ignores it.
+ - e.g. <system-out> from a <testcase> is shown.
+ - The logger only puts console text (<system-out> and <system-err>) in the <testsuite> level (not into <testcase>) so CircleCI ignores it.
 -->
 For each failed test (i.e. for each JUnit `<testcase>` element containing a failure or an error),
 CircleCI only shows the testcase's failure/error message, any text within the failure/error element, plus any `<system-out>` or `<system-err>` text.
@@ -36,9 +37,11 @@ This can provide important/useful information,
 especially if the test failure message is insufficiently informative on its own.
 
 - `Default`:
+
   ![FailureBodyFormat Default](assets/circleci-test-expanded-with-failure-default.png)
 
 - `Verbose`:
+
   ![FailureBodyFormat Verbose](assets/circleci-test-expanded-with-failure-verbose.png)
 
 ### MethodFormat
@@ -46,8 +49,9 @@ especially if the test failure message is insufficiently informative on its own.
 CircleCI shows the class names of each failed test so setting `MethodFormat=Class` or `MethodFormat=Full` provides no further information on the CircleCI UI; the effect is purely cosmetic and is a matter of personal preference.
 
 - `Default`:
+
   ![MethodFormat Default](assets/circleci-test-collapsed-with-methodname-default.png)
-- `Class`:
+
+- `Class` and `Full`:
+
   ![MethodFormat Class](assets/circleci-test-collapsed-with-methodname-class.png)
-- `Full`:
-  Same as `Class`.