Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation improvements for 1.0 release #1620

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

FrankRay78
Copy link
Contributor

@FrankRay78 FrankRay78 commented Aug 24, 2024

The following PR spectreconsole/examples#1 should be reviewed/merged at the same time as this one.


fixes #1602

  • I have read the Contribution Guidelines
  • I have commented on the issue above and discussed the intended changes
  • A maintainer has signed off on the changes and the issue was assigned to me
  • All newly added code is adequately covered by tests
  • All existing tests are still running without errors
  • The documentation was modified to reflect the changes OR no documentation changes are required.

Changes


Please upvote 👍 this pull request if you are interested in it.

@FrankRay78 FrankRay78 added this to the 1.0 milestone Aug 24, 2024
@FrankRay78 FrankRay78 self-assigned this Aug 24, 2024
@FrankRay78 FrankRay78 marked this pull request as draft August 24, 2024 16:02
@FrankRay78 FrankRay78 changed the title Documentation improvements for 1.0 release (WIP) Documentation improvements for 1.0 release Aug 24, 2024
@FrankRay78 FrankRay78 marked this pull request as ready for review August 24, 2024 20:36
@FrankRay78
Copy link
Contributor Author

@patriksvensson I've addressed your earlier review comments and rebased against main, fixing conflicts. This PR is now ready for another review +/ merging.

IMPORTANT: The following PR spectreconsole/examples#1 should be reviewed/merged at the same time as this one.

@FrankRay78 FrankRay78 force-pushed the Documentation_improvements_for_version_1.0 branch from 281a16a to 8ec71c0 Compare September 17, 2024 10:24
@FrankRay78 FrankRay78 modified the milestones: 1.0, 0.50 Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: PR 📬
Development

Successfully merging this pull request may close these issues.

Broken Documentation Link to Dependency Injection Example (and possible documentation improvements)
2 participants