CXPLA-89: Replace AutomaticallyUseReferenceAssemblyPackages with nuget #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamhathcock
requested changes
Sep 26, 2024
Directory.Packages.props
Outdated
| @@ -38,5 +38,6 @@ | |||
| <GlobalPackageReference Include="PolySharp" Version="1.14.1" /> | |||
| <GlobalPackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" /> | |||
| <GlobalPackageReference Include="Speckle.InterfaceGenerator" Version="0.9.6" /> | |||
| <GlobalPackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.3" PrivateAssets="All" /> | |||
There was a problem hiding this comment.
Don't need PrivateAssets since you're using GlobalPackageReference https://learn.microsoft.com/en-us/nuget/consume-packages/central-package-management#global-package-references
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #284 +/- ##
=====================================
Coverage 8.43% 8.43%
=====================================
Files 231 231
Lines 4567 4567
Branches 562 562
=====================================
Hits 385 385
Misses 4165 4165
Partials 17 17 ☔ View full report in Codecov by Sentry. |
adamhathcock
approved these changes
Sep 26, 2024
AlanRynne
deleted the
alan/CXPLA-89-AutomaticallyUseReferenceAssemblyPackages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideal scenario would be that no changes to any lock file happen locally in any machine from this commit onwards.