Cannot edit childCO in a COG

[emenslin]

Describe the bug
If you edit a CO through the children subview in a COG the save button is not enabled and you can't save, if you make a change to the COG form to enable the save button it throws an out of date error. This might already be an existing issue but I could not find it.

To Reproduce
Steps to reproduce the behavior:

1. Go to COG
2. Add ChildCO
3. Expand CO
4. Edit a field
5. See save is not enabled
6. Change something on the COG form
7. Save
8. See error

Expected behavior
You should be able to edit a CO in the COG form.

Screenshots

chrome_aK4ADOhQWB.mp4

Crash Report

Specify 7 Crash Report - 2024-12-17T16_47_13.357Z.txt

Please fill out the following information manually:

• OS: Windows 11
• Browser: Chrome
• Specify 7 Version: production
• Database Name: ojsmnh
• Collection name: fossil invertebrates
• User Name: spadmin
• URL: https://ojsmnh20241003wb-production.test.specifysystems.org/specify/

[grantfitzsimmons]

Seems this was broken at some point in Geo development. This was reported as a usability concern by André and Soraya from the Geology Swiss steering committee

[melton-jason]

This is ultimately because some part of one-to-one relationships are not being properly supported.

More specifically in this case: the change/saverequired event in the CollectionObject is not being propagated up to the CollectionObjectGroupJoin and CollectionObjectGroup resources.

This behavior is handled via the the event handlers in resourceApi.ts:

specify7/specifyweb/frontend/js_src/lib/components/DataModel/resourceApi.ts

Lines 36 to 87 in b69dac3

	function eventHandlerForToOne(related, field) {
	return function (event) {
	const args = _.toArray(arguments);
	switch (event) {
	case 'saverequired': {
	this.handleChanged();
	return;
	}
	case 'change:id': {
	this.set(field.name, related.url());
	return;
	}
	case 'changing': {
	this.trigger.apply(this, args);
	return;
	}
	}
	// Pass change:field events up the tree, updating fields with dot notation
	const match = /^r?(change):(.*)$/.exec(event);
	if (match) {
	args[0] = `r${match[1]}:${field.name.toLowerCase()}.${match[2]}`;
	this.trigger.apply(this, args);
	}
	};
	}
	function eventHandlerForToMany(related, field) {
	return function (event) {
	const args = _.toArray(arguments);
	switch (event) {
	case 'changing': {
	this.trigger.apply(this, args);
	break;
	}
	case 'saverequired': {
	this.handleChanged();
	break;
	}
	case 'change':
	case 'add':
	case 'remove': {
	// Annotate add and remove events with the field in which they occurred
	args[0] = `${event}:${field.name.toLowerCase()}`;
	this.trigger.apply(this, args);
	Reflect.apply(this.trigger, this, ['change', this, related]);
	break;
	}
	}
	};
	}

specify7/specifyweb/frontend/js_src/lib/components/DataModel/resourceApi.ts

Lines 141 to 146 in b69dac3

	this.on('change', function () {
	if (!this._fetch && !this._save) {
	this.handleChanged();
	this.trigger('saverequired');
	}
	});

For which the saverequired event is caught by the useIsModified hook:

specify7/specifyweb/frontend/js_src/lib/hooks/useIsModified.tsx

Lines 9 to 46 in b69dac3

	export function useIsModified(
	resource: SpecifyResource<AnySchema> | undefined,
	// Whether a new resource that hasn't been modified is treated as not modified
	ignoreBrandNew = true
	): boolean {
	const [saveRequired, handleNeedsSaving, handleSaved] = useBooleanState(
	resource?.needsSaved === true && (!resource?.isNew() || !ignoreBrandNew)
	);
	// Recompute default value when resource changes
	React.useEffect(
	() =>
	resource?.needsSaved === true && (!resource?.isNew() || !ignoreBrandNew)
	? handleNeedsSaving()
	: handleSaved(),
	[resource, ignoreBrandNew, handleNeedsSaving, handleSaved]
	);
	// Listen for "saveRequired"
	React.useEffect(
	() =>
	typeof resource === 'object'
	? resourceOn(resource, 'saveRequired', tap(handleNeedsSaving), false)
	: undefined,
	[resource, handleNeedsSaving]
	);
	// Listen for "saved"
	React.useEffect(
	() =>
	typeof resource === 'object'
	? resourceOn(resource, 'saved', handleSaved, false)
	: undefined,
	[resource, handleSaved]
	);
	return saveRequired;
	}

I imagine most of the work for this fix would be investigating why the event(s) are not being propagated: the actual change would likely be a very small one